Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StencilClient configured with ondemandRefresh doesn't refresh for nested protos #77

Open
sravankorumilli opened this issue Sep 21, 2021 · 0 comments
Open

StencilClient configured with ondemandRefresh doesn't refresh for nested protos #77

sravankorumilli opened this issue Sep 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@sravankorumilli
Copy link
Contributor

sravankorumilli commented Sep 21, 2021 •
edited

Describe the bug
Stencil Client when configured for ondemand refresh it uses ProtoParserWithRefresh which checks for any unknownfields and refreshes the cache, but unknownfields does check only in the root proto, so for nested protos if there are new fields being added it won't refresh the cache.

To Reproduce
Create a proto & add a new field at a nested level or modify an enum this should be reproduced in that case while deserializing
@h4rikris h4rikris added the bug Something isn't working label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sravankorumilli @h4rikris