Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles don't like parentheses #174

Open
Scoffins opened this issue Jan 3, 2024 · 1 comment
Open

Subtitles don't like parentheses #174

Scoffins opened this issue Jan 3, 2024 · 1 comment

Comments

@Scoffins
Copy link

Scoffins commented Jan 3, 2024

New to GitHub so apologies if my terminology isn't correct.
I am using your latest update in "new-submaker" and mostly works great, but if the input text file contains a parentheses"(" or ")" right before the pattern character used for splitting, it stops outputting the subtitle right after that character.

E.g. if text file contains "Hello mate (friend). How are you?" it will stop right after (friend)

It also seems to happen if it's curly brackets {} aswel as parentheses.

Hope this makes sense.

@rany2
Copy link
Owner

rany2 commented Mar 14, 2024

It does make sense and I do know why this happens, the new-submaker code isn't great; I mostly got it from a PR I initially merged to master but it had too many issues that I just decided to not bother with it. I intend to redo it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants