Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Color themes #690

Open
AxelSkye opened this issue Nov 4, 2023 · 2 comments
Open

[Feature] Color themes #690

AxelSkye opened this issue Nov 4, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AxelSkye
Copy link

AxelSkye commented Nov 4, 2023

Is your feature request related to a problem? Please describe.
If you use multiple profiles or just want some customization a common way is to choose a color theme. Standard Firefox themes change tabs' outline, but it would be cool if they applied the color while keeping all the theme customization. Even though libadwaita doesn't include this, it would be a good balance between looking stock and being customizable.

Describe the solution you'd like
Offer color "accents" or apply Firefox's themes color.

New Google Chrome refreshed desgin handles this quite good, using custom colors with both light and dark theme support, the same + this customization for Firefox would be amazing.

@AxelSkye AxelSkye added the enhancement New feature or request label Nov 4, 2023
@rafaelmardojai
Copy link
Owner

You could use something like Gradience that also supports tweaking this theme, but you will get the customization in all GTK apps. An advanced alternative would be to use the Gradience output or manually editing the colors CSS files of the theme (firefox-gnome-theme/theme/colors) where you can edit each CSS variable.

About supporting Firefox color themes, I haven't investigated if it is feasible to support it but I also lack the motivation.

@rafaelmardojai rafaelmardojai added the help wanted Extra attention is needed label Nov 21, 2023
@Zetta1Reid0
Copy link

Okkkk . So why doesn't the theme actually use Firefox predefined variables for colors ? See : https://developer.mozilla.org/en-US/docs/Web/CSS/Mozilla_Extensions#values. That way this theme can pick up color from your gtk theme directly. And since most people actually either patch libadwaita to support theming ,use global variable GTK_THEME to force the theme or use the "@include" rule to override whole theme from user "&XDG_CONFIG_DIR/gtk-4.0/gtk.css" config file , because Adwaita theme is ugly for some (if not most) people and doesn't match their gtk theme. There could also be a switch to use libadwaita defines colors . See : https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/named-colors.html . As for motivation this should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants