typed: Remove extra call to current-test-case-around
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary to wrap a test case in `current-test-case-around`; that will be done later. Doing so increments the running test count (and, possibly, the running test failure count) twice. closes racket#132
jessealama
changed the title
current-test-case-aroundcurrent-test-case-around
|
I think the problem isn't that this macro expands to a use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to wrap a test case in
current-test-case-around; that will be done later. Doing so increments the running test count (and, possibly, the running test failure count) twice.The proposed change may seem implausible on its face. I also feel somewhat less than confident that this is the right thing to do. But I can confirm that this does the job.
closes #132