Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR (allow login without cookies) #5

Open
jonthegeek opened this issue Mar 22, 2022 · 2 comments
Open

GDPR (allow login without cookies) #5

jonthegeek opened this issue Mar 22, 2022 · 2 comments

Comments

@jonthegeek
Copy link
Member

Show the cookie warning on the auth code version of the page. If they say no, put their token in the url, and then parse it, I think? See what's recommended. Maybe set it with setenv and then load the ui? I'm not sure I can make that work.

Research token in query string first.

@jonthegeek
Copy link
Member Author

I think I'd want to pass it in a header. Probably still a good idea to encrypt these tokens, even in the cookies. Of course if the app decrypts them... That doesn't do anything useful, so maybe not?

@jonthegeek jonthegeek changed the title GDPR GDPR (allow login without cookies) Mar 28, 2022
@jonthegeek
Copy link
Member Author

The beginning of the login is the same regardless, with a "Sign in with Slack" button.

When they return from Slack with a code in the URL, ask if it's ok to set a cookie. If yes, set the cookie like we do now, and reload. If they say no, pass the token <in a secure way TBD, maybe just encoded in the url or in the header?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant