Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for bad code #32

Open
jonthegeek opened this issue Oct 7, 2022 · 1 comment
Open

Add error handling for bad code #32

jonthegeek opened this issue Oct 7, 2022 · 1 comment

Comments

@jonthegeek
Copy link
Member

When we call slackteams::add_team_code(), we should capture any errors, and display a more specific error message (rather than letting the shiny app crash). The error in the log is:

Error in slackteams::add_team_code: Failed to validate code. Slack returned: invalid_code

To the user, that shows up as:

An error has occurred!
An error has occurred. Check your logs or contact the app author for clarification.
@jonthegeek
Copy link
Member Author

Probably include a button that removes the code from the url and reloads (ie, takes them to the app itself, to login or whatever). This probably only happens when someone is manually testing, though, so I don't know how important that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant