Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on Windows, create_file_dialog() is not disposing of dialog after ShowDialog() #1383

Open
pemn opened this issue May 14, 2024 · 1 comment
Open

Comments

@pemn
Copy link

pemn commented May 14, 2024

Specification

  • pywebview version:
    1.4.2
  • operating system:
    Windows 10.0.22000.2899
  • web renderer:
    webview.platforms.winforms

Description

When calling any create_file_dialog(), the dialog is not being disposed (dialog.Dispose()). So the python process does not finish after the main window is closed. Not even keyboard interrupt (CTRL+C) will terminate the process. Only taskkill is able to kill the python process.
Im not sure if calling dialog.Dispose() will be enough to fix the issue, but thats a good start.

images and a minimal test file on the zip:

test_bug_filedialog.zip

Practicalities

  • YES/NO I am willing to work on this issue myself.
    NO
  • YES/NO I am prepared to support this issue financially.
    NO
@r0x0r
Copy link
Owner

r0x0r commented May 29, 2024

I ran your example and could not reproduce the problem. If calling dialog.Dispose() solves it for you, feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants