Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print v3 to v4 translated code in console #854

Open
ar-puuk opened this issue Mar 31, 2024 · 6 comments
Open

print v3 to v4 translated code in console #854

ar-puuk opened this issue Mar 31, 2024 · 6 comments
Labels
compat v3 to v4 transition

Comments

@ar-puuk
Copy link

ar-puuk commented Mar 31, 2024

If the package is automatically translating the code from v3 to v4, would it be possible to make the translation print in the console, at least for learning purposes?

It could be a global option.

#> tm_lines: Deprecated tmap v3 code detected. Code translated to v4
#> charts not implemented in view mode
@mtennekes
Copy link
Member

Yes, good idea. Not sure about the amount of work that this will take.
As long as this issue is open, I'll considering it.

@olivroy olivroy added the compat v3 to v4 transition label Apr 11, 2024
@jose-m-maciasiii
Copy link

Support! Mainly I am trying to figure out how to use the v3 legend.hist = TRUE in the new style

@Nowosad
Copy link
Member

Nowosad commented Apr 14, 2024

@jose-m-maciasiii see #842

@mtennekes
Copy link
Member

Done! fa7c6e5

Well, not meant for 100% copy-paste, but with a series of messages that also has an educational value (hopefully).

I've tested most of the examples from v3. Please check

@ar-puuk
Copy link
Author

ar-puuk commented Apr 26, 2024

Thanks a lot. That was a lot of effort you have put into it (I checked the commit). As you said, it is not 100% copy-paste, but it's helpful to begin the edits. There seems to be a lot to learn.

I really appreciate all the effort.

@mtennekes
Copy link
Member

Thx. Our aim is to make tmap much more intuitive: rather than having to go through a huge list of arguments (even myself!), the systematic approach of v4 will make it a lot easier (hopefully) to find what you're after.

Making it 100% copy-paste is of course possible, but not sure if it's worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat v3 to v4 transition
Projects
None yet
Development

No branches or pull requests

5 participants