Install pandoc

[gaborcsardi]

Always? Should be fast enough.

[ms609]

Could this be as simple as adding

      - uses: r-lib/actions/setup-pandoc@v2

as a step in the rhub.yaml template file?

This adds 1s when run, which I think counts as "fast enough"!

[ms609]

Addendum: now I come to try this with valgrind/asan I see that this suggestion works for other-platforms:, but not linux-containers:, where sudo is not available – I see now that this is perhaps more complicated than it first appears!

[gaborcsardi]

where sudo is not available

You can run the command without sudo.

[ms609]

I didn't see an obvious way to configure the setup-pandoc action to run without sudo.

[gaborcsardi]

Oh, right, sry, I meant that you can install pandoc with the OS package manager. setup-pandoc is not going to work on the Fedora containers, anyway.

[gaborcsardi]

But again, in these cases you don't actually need to build the vignettes.

[danielinteractive]

Agree that this would be important, I also just got

Error running filter pandoc-citeproc:
Could not find executable pandoc-citeproc

on clang18.

[chrismainey]

Agree that this would be important, I also just got

Error running filter pandoc-citeproc:
Could not find executable pandoc-citeproc

on clang18.

Also receiving this, missing pandoc-citeproc on ubuntu clang and 'linux (R-devel)' to Ubuntu 22.04.4.
Checks on same package complete fine on windows with R-devel, other linux versions with R-current, and mac OS with R-current and R-devel.

Log:
Run r-hub/actions/run-check@v1
Run r-lib/actions/check-r-package@v2
Run ## --------------------------------------------------------------------
── R CMD build ─────────────────────────────────────────────────────────────────

• checking for file ‘.../DESCRIPTION’ ... OK
• preparing ‘FunnelPlotR’:
• checking DESCRIPTION meta-information ... OK
• installing the package to build vignettes
• creating vignettes ... ERROR
  Error: --- re-building ‘changing_funnel_plot_options.Rmd’ using rmarkdown
  --- finished re-building ‘changing_funnel_plot_options.Rmd’
  --- re-building ‘funnel_plots.Rmd’ using rmarkdown
  Warning: Warning: ggrepel: 4 unlabeled data points (too many overlaps). Consider increasing max.overlaps
  Error running filter pandoc-citeproc:
  Could not find executable pandoc-citeproc
  Error: Error: processing vignette 'funnel_plots.Rmd' failed with diagnostics:
  pandoc document conversion failed with error 83
  --- failed re-building ‘funnel_plots.Rmd’
  SUMMARY: processing the following file failed:
  ‘funnel_plots.Rmd’
  Error: Error: Vignette re-building failed.
  Execution halted
  Error: Error in proc$get_built_file() : Build process failed
  Calls: ... build_package -> with_envvar -> force ->
  Execution halted
  Error: Process completed with exit code 1.
  Run ## --------------------------------------------------------------------
  Show testthat output
  Run # Show output of installation, examples and tests
  Show installation output
  Show output of examples and tests
  Run # Save binary package
  Save binary package
  Could not find binary package.
  Run actions/upload-artifact@v4
  Warning: No files were found with the provided path: check. No artifacts will be uploaded.

[gaborcsardi]

@danielinteractive @chrismainey Can you please link to a failing build? Thanks!

[gaborcsardi]

Never mind, this should be fixed now: https://github.com/gaborcsardi/FunnelPlotR/actions/runs/9018187734/job/24778227972

Please reopen or open another issue if you still have problems with Pandoc. Thanks!