Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batch requests to all Grouping APIs #2326

Open
keotic opened this issue Jul 25, 2023 · 4 comments · May be fixed by #3698
Open

Support batch requests to all Grouping APIs #2326

keotic opened this issue Jul 25, 2023 · 4 comments · May be fixed by #3698
Labels
enhancement New feature or request

Comments

@keotic
Copy link

keotic commented Jul 25, 2023

Is your feature request related to a problem? Please describe.
For production pipelines that require high throughput it is common to buffer and batch incoming requests before passing them
to the Model Encoding stage in the pipeline (i.e transforming Text / Image / Voice into a vector).
Therefore in production systems we usually need to handle parallel batches of queries.

Currently all Grouping APIs are for single vectors, making these much appreciated and useful APIs a production bottleneck.

Describe the solution you'd like
Add batching APIs for the Grouping APIs (and any new APIs in mind :))
https://qdrant.tech/documentation/concepts/search/#grouping-api
@joein
Copy link
Member

joein commented Jul 27, 2023

Was also asked in Discord https://discord.com/channels/907569970500743200/1134119750260236378

@agourlay agourlay added the enhancement New feature or request label Aug 30, 2023
@generall generall added the good first issue Good for newcomers label Dec 25, 2023
@Snehil-Shah
Copy link

@agourlay @generall I want to work on this..
should I make an endpoint like /collections/{collection_name}/points/search/groups/batch ? Would really appreciate some initial guidance..

@carlosb1
Copy link

Checking this... to be sure, I see different cases:

  • Improve API to permit queries with batches, to receive different types in the responses
  • (from discord thread), modify from the current implementation to permit grouping queries with some incorrect ID, then it should return only the correct ones.
    Is it correct?

@generall
Copy link
Member

(from discord thread), modify from the current implementation to permit grouping queries with some incorrect ID, then it should return only the correct ones.

this is a separate issue, it should be discussed separatelly

@acrrd acrrd linked a pull request Feb 26, 2024 that will close this issue
Draft
9 tasks
@generall generall removed the good first issue Good for newcomers label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add batching api for groups acrrd/qdrant
6 participants
@agourlay @carlosb1 @generall @keotic @joein @Snehil-Shah