Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LandSeaFalseColorCompositor #2722

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add LandSeaFalseColorCompositor #2722

wants to merge 1 commit into from

Conversation

TAlonglong
Copy link
Collaborator

Add a compositor using the window IR channel, a land sea mask and computing a color palette based on these to generate a false color image. Clouds are shades of gray to white from the brightness temperature(IR window channel), land is greenish and sea is blueish.

Here is an small example using the FCI ir_105

land_sea_false_color_20240104_093000

With a composites config section as this:

  _land_sea_mask:
    compositor: !!python/name:satpy.composites.StaticImageCompositor
    standard_name: land_sea_mask
    filename: /home/trygveas/testdata/static_images/test_20140111_120000.tif

  land_sea_false_color:
    compositor: !!python/name:satpy.composites.LandSeaFalseColorCompositor
    standard_name: null_enhancement
    prerequisites:
      - ir_105
      - _land_sea_mask

@TAlonglong
Copy link
Collaborator Author

It is possible that this can be achieved by using the palettized enhancement together with a mask from the land sea mask.

I have not looked into this, so I'm not sure if this is possible.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (bca22b4) 95.40% compared to head (adb4505) 95.24%.

Files Patch % Lines
satpy/composites/__init__.py 4.21% 91 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
- Coverage   95.40%   95.24%   -0.17%     
==========================================
  Files         371      371              
  Lines       52825    52920      +95     
==========================================
+ Hits        50399    50403       +4     
- Misses       2426     2517      +91
Flag Coverage Δ
behaviourtests 4.15% <4.21%> (+<0.01%) ⬆️
unittests 95.85% <4.21%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud
Copy link
Member

I've done something similar in the past, using only configuration and palettes, I can try to dig it out if you want...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7552334306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.802%
Totals Coverage Status
Change from base Build 7472442128: -0.2%
Covered Lines: 50529
Relevant Lines: 52743
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese Awaiting requested review from djhoese djhoese will be requested when the pull request is marked ready for review djhoese is a code owner

@mraspaud mraspaud Awaiting requested review from mraspaud mraspaud will be requested when the pull request is marked ready for review mraspaud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False color compositor using a land sea mask to colorize IR window channel
3 participants
@TAlonglong @mraspaud @coveralls