Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lintrunner failures on main #126386

Open
Flamefire opened this issue May 16, 2024 · 0 comments
Open

lintrunner failures on main #126386

Flamefire opened this issue May 16, 2024 · 0 comments
Labels
module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Flamefire
Copy link
Collaborator

馃悰 Describe the bug

I installed lintrunner as per https://github.com/pytorch/pytorch/wiki/lintrunner :

python -m venv --system-site-packages ../pt_Venv
. ../pt_Venv/bin/activate
pip install lintrunner
lintrunner init

I then ran it with lintrunner --all-files on main (after it failed on a branch I wanted to PR) and I get a lot of errors from MYPY. E.g.

  Error (MYPY) [safe-super]
    Call to abstract method "query" of "_EventBase" with trivial body via
    super() is unsafe

        141  |            A boolean indicating if all work currently captured by event has
        142  |            completed.
        143  |        """
    >>> 144  |        return super().query()

  Error (MYPY) [name-defined]
    Name "torch._C._XpuStreamBase" is not defined

         12  |    torch._C.__dict__["_XpuEventBase"] = _dummy_type("_XpuEventBase")
         13  |
         14  |
    >>>  15  |class Stream(torch._C._XpuStreamBase, _StreamBase):
         16  |    r"""Wrapper around a XPU stream.
         17  |
         18  |    A XPU stream is a linear sequence of execution that belongs to a specific

Are those supposed to fail or am I missing anything?

Versions

OS: Linux Mint 21.3 (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 14.0.0-1ubuntu1.1
CMake version: version 3.22.1
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-105-generic-x86_64-with-glibc2.35

Versions of relevant libraries:
[pip3] flake8==6.1.0
[pip3] flake8-bugbear==23.3.23
[pip3] flake8-comprehensions==3.12.0
[pip3] flake8-executable==2.1.3
[pip3] flake8-logging-format==0.9.0
[pip3] flake8-pyi==23.3.1
[pip3] flake8-simplify==0.19.3
[pip3] mypy==1.9.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.0
[pip3] optree==0.11.0
[conda] Could not collect

@mikaylagawarecki mikaylagawarecki added module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

2 participants