Broken Link and unfinished sentence in Frequently Asked Questions #126367
Labels
actionable
module: docs
Related to our documentation, both in docs/ and docblocks
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
馃摎 The doc issue
In the
torch.compiler_faq.rst
file, there is a sentence that reads: The basic strategy for optimizing DDP with Dynamo is outlined in distributed.py where the main idea will be to graph break on DDP bucket boundaries.However, the hyperlink that should lead to
distributed.py
is not functioning correctly. When clicked, it does not redirect to the intended destination, it seems the file is no longer available at the specified location.In the same file, there is an unfinished sentence that reads:
For example, Inductor first takes care of fusing whatever it can and only then generates Triton kernels. It can also
This sentence ends abruptly and does not provide complete information.
Suggest a potential alternative/fix
I believe the distributed.py file mentioned in the documentation might be located at
torch/_dynamo/backends/distributed.py
. If this is the correct file, updating the hyperlink to point to this location should resolve the issue. However, please verify this as I might be mistaken.Regarding the unfinished sentence I believe the
It can also
can be removed, but if there is something more to be said it should be completed.cc @svekars @brycebortree
The text was updated successfully, but these errors were encountered: