Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected MYPY linter errors on CI #126361

Open
huydhn opened this issue May 16, 2024 · 0 comments
Open

Unexpected MYPY linter errors on CI #126361

huydhn opened this issue May 16, 2024 · 0 comments
Assignees
Labels
module: ci Related to continuous integration module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@huydhn
Copy link
Contributor

huydhn commented May 16, 2024

Recently, there have been reports of unexpected MYPY linter errors on CI that sometimes requires killing MYPY daemon to surface. There was also an incident today captured on HUD https://hud.pytorch.org/hud/pytorch/pytorch/9c9d0c2fab650a8805421ec6641a3e20be31a53b/1?per_page=50 where some MYPY linter failures come and go unexpectedly.

cc @seemethere @malfet @pytorch/pytorch-dev-infra @ZainRizvi @kit1980 @clee2000 @ezyang

@huydhn huydhn added module: devx Related to PyTorch contribution experience (HUD, pytorchbot) module: ci Related to continuous integration labels May 16, 2024
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2024
pytorchmergebot pushed a commit that referenced this issue May 16, 2024
MYPY somehow shows lots of local failures for me.  The issue is tracked in #126361.  This is only to keep trunk sane.  These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: #126378
Approved by: https://github.com/kit1980
pytorchmergebot pushed a commit that referenced this issue May 16, 2024
MYPY somehow shows lots of local failures for me.  The issue is tracked in #126361.  This is only to keep trunk sane.  These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.

Pull Request resolved: #126378
Approved by: https://github.com/kit1980
pytorchmergebot pushed a commit that referenced this issue May 17, 2024
This PR is based on #125440, additionally merging the latest main branch and fixing the lint failures from #126361.

Pull Request resolved: #126375
Approved by: https://github.com/janeyx99
ZelboK pushed a commit to ZelboK/pytorch that referenced this issue May 19, 2024
MYPY somehow shows lots of local failures for me.  The issue is tracked in pytorch#126361.  This is only to keep trunk sane.  These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help.
Pull Request resolved: pytorch#126378
Approved by: https://github.com/kit1980
ZelboK pushed a commit to ZelboK/pytorch that referenced this issue May 19, 2024
MYPY somehow shows lots of local failures for me.  The issue is tracked in pytorch#126361.  This is only to keep trunk sane.  These two line were added by pytorch#126035 as an attempt to fix lint there, but didn't seem to help.

Pull Request resolved: pytorch#126378
Approved by: https://github.com/kit1980
ZelboK pushed a commit to ZelboK/pytorch that referenced this issue May 19, 2024
This PR is based on pytorch#125440, additionally merging the latest main branch and fixing the lint failures from pytorch#126361.

Pull Request resolved: pytorch#126375
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ci Related to continuous integration module: devx Related to PyTorch contribution experience (HUD, pytorchbot) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: In Progress
Development

No branches or pull requests

2 participants