Add support for MPS Backend [without torch.amp.autocast ]
#2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module: distributed
guptaaryan16
changed the title
MPS Backend [without torch.amp.autocast ]MPS Backend [without torch.amp.autocast ]
vfdev-5
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Thanks @guptaaryan16 , I'll merge this PR into "mps" branch and later will fix all CI related issues and also add more mps tests.
3 tasks
vfdev-5
added a commit
that referenced
this pull request
Nov 22, 2023
* Add support for `MPS` Backend [without torch.amp.autocast ] (#2993) * Add support for "mps" device in ignite.distributed.base * Made changes in the supervised_trainer API to have mps devices, Added some tests * autopep8 fix * Added lint fixes * Setup ci for mps tests --------- Co-authored-by: guptaaryan16 <guptaaryan16@users.noreply.github.com> Co-authored-by: vfdev <vfdev.5@gmail.com> * Fixed mps-tests.yml * More fixes to mps-tests.yml * Set up working directory in mps yml * another try * another try * another try * added version check and skipped mps tests * code formatting * another code formatting fix --------- Co-authored-by: Aryan Gupta <97878444+guptaaryan16@users.noreply.github.com> Co-authored-by: guptaaryan16 <guptaaryan16@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2977
Description: I have added support for
mpsdevices through this PR and currently it uses (https://pytorch.org/docs/stable/notes/mps.html). Right now I have not just integrated any CI but it is in progress.Check list: