Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of schedulers support in setup_common_training_handlers #2289

Open
vfdev-5 opened this issue Oct 22, 2021 · 4 comments
Open

List of schedulers support in setup_common_training_handlers #2289

vfdev-5 opened this issue Oct 22, 2021 · 4 comments

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 22, 2021

馃殌 Feature

Feature request to support the case like :

common.setup_common_training_handlers(
        trainer=trainer,
        ...
        lr_scheduler=[lr_scheduler1, lr_scheduler2],
    )

cc @DhDeepLIT

@KickItLikeShika
Copy link
Contributor

Will work on this, may take some time thinking about how to test this properly

@KickItLikeShika KickItLikeShika self-assigned this Oct 27, 2021
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 27, 2021

@KickItLikeShika we haven't yet triaged it as required enhancement.
Tricky part may be also on which events to attach schedulers. Even for a single lr_scheduler it may be not expected to have it on iterations vs epochs

@KickItLikeShika KickItLikeShika removed their assignment Oct 27, 2021
@KickItLikeShika
Copy link
Contributor

@vfdev-5 yeah I see, once we sort something out, I'm interested in working on this, will look for something else for now, thanks!

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 27, 2021

I think either us or @DhDeepLIT can suggest an API for that and once we are agreed on it we can move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants