Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure python version is compatible before building wheels #3570

Open
Ciao-Wen-Chen opened this issue May 10, 2024 · 3 comments
Open

Ensure python version is compatible before building wheels #3570

Ciao-Wen-Chen opened this issue May 10, 2024 · 3 comments
Assignees
Labels
module: build Related to buck2 and cmake build module: doc Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Ciao-Wen-Chen
Copy link

Hi I got the following error message after running instruction from page

./install_requirements.sh --pybind

build_meta.py", line 311, in run_setup
exec(code, locals())
File "", line 549, in
TypeError: 'type' object is not subscriptable
Preparing wheel metadata ... error

image

@mergennachin
Copy link
Contributor

mergennachin commented May 13, 2024

@Ciao-Wen-Chen Looks like you're using python 3.8

ExecuTorch runs on python 3.10 and above.

@dbort - once actionable thing is to update our setup page (https://pytorch.org/executorch/main/getting-started-setup.html) to include supported python versions more upfront on the top as opposed to part of the conda creation step.

@mergennachin mergennachin added module: doc Related to our documentation, both in docs/ and docblocks module: build Related to buck2 and cmake build triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 13, 2024
@dbort dbort changed the title package download facing 'type' object is not subscriptable Ensure python version is compatible before building wheels May 13, 2024
@dbort
Copy link
Contributor

dbort commented May 13, 2024

Updating the docs makes sense; I thought we already mentioned it, but we don't.

We should also update install_requirements.sh and maybe setup.py to explicitly check for a compatible python version.

@Ciao-Wen-Chen
Copy link
Author

yeah, I pointed to the wrong Python version. Get the build successfully, thank you for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: build Related to buck2 and cmake build module: doc Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants