You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Save and Update mixins for protectedbranch doesn't really work for most of it's attributes, as the PATCH/POST api use different values from those return by the API.
To be able to update to update either `allowed_to_push' GitLab protected branch state.
Actual Behavior
Using the python-gitlab library to modify the push_access_levels attribute that the object has and then calling .save() appears to do nothing, and the python object has no allowed_to_push attribute to modify.
It does work for the basic .allow_force_push protectedbranch attribute, as added and tested in the original Pull Request.
I think historically we have left issues like this up to the user to handle. As I think the idea of python-gitlab is to be a thin wrapper over the GitLab API. The positive to doing this is it makes things easier for the users. The negative is that it adds more work for the volunteer developers of python-gitlab to add this and there are other inconsistencies in the upstream API that would thus wanted to be added. And then the maintenance of this if GitLab changes the API.
This might be a good thing to raise upstream and ask GitLab to resolve this inconsistency.
Description of the problem, including code/CLI snippet
Breaking out discussion from this Pull Request thread into its own issue.
The Save and Update mixins for
protectedbranch
doesn't really work for most of it's attributes, as the PATCH/POST api use different values from those return by the API.The PATCH api requires to send
allowed_to_push attribute
, but the returned attribute ispush_access_levels
, as documented in the API and examples: https://docs.gitlab.com/ee/api/protected_branches.html#example-update-a-push_access_level-recordExpected Behavior
To be able to update to update either `allowed_to_push' GitLab protected branch state.
Actual Behavior
Using the python-gitlab library to modify the
push_access_levels
attribute that the object has and then calling.save()
appears to do nothing, and the python object has noallowed_to_push
attribute to modify.It does work for the basic
.allow_force_push
protectedbranch attribute, as added and tested in the original Pull Request.Specifications
v4
gitlab.com
The text was updated successfully, but these errors were encountered: