Fix _after_postgeneration being invoked twice #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarzi
reviewed
Jun 6, 2022
| """Get the local namespace of the caller frame.""" | ||
| return sys._getframe(depth).f_locals | ||
| return sys._getframe(depth + 2).f_locals |
There was a problem hiding this comment.
why this change is required?
There was a problem hiding this comment.
not needed, but it makes more sense, so that the caller can specify if it wants the locals from the caller (from its POV) or levels from its POV
| @@ -291,6 +291,24 @@ def evaluate(request: SubRequest, value: LazyFixture[T] | T) -> T: | |||
| return value.evaluate(request) if isinstance(value, LazyFixture) else value | |||
|
|
|||
|
|
|||
| def noop(*args: Any, **kwargs: Any) -> None: | |||
| """No-op function.""" | |||
| pass | |||
There was a problem hiding this comment.
NIP: pass is not required when docstring is provided
|
|
||
| def test_postgeneration_called_once(self, request): | ||
| """Test that ``_after_postgeneration`` is called only once.""" | ||
| foo = request.getfixturevalue("collector") |
There was a problem hiding this comment.
why not add collector as a test's function argument to let pytest do the job of getting the fixture value?
There was a problem hiding this comment.
it's just in case there is an error in the setup, it's nicer to have the tests error out at runtime, rather than at collection time (especially if doing TDD), as it would prevent you from running other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #156.