Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose, document, and demonstrate AZP variants #170

Open
Tracked by #280
jGaboardi opened this issue Jun 19, 2021 · 5 comments
Open
Tracked by #280

Expose, document, and demonstrate AZP variants #170

jGaboardi opened this issue Jun 19, 2021 · 5 comments

Comments

@jGaboardi
Copy link
Member

jGaboardi commented Jun 19, 2021

Currently the standard AZP algorithm is shown in the docs and demonstrated in the Tutorials. However, there are 3 variants of AZP available in spopt:

These three variants are not exposed in the API and don't appear to be fully functional.

@jGaboardi jGaboardi changed the title Document and demonstrate AZP variants Expose, document, and demonstrate AZP variants Jun 20, 2021
@jGaboardi jGaboardi added this to the Release +1 following v0.2.0 milestone Aug 5, 2021
@jGaboardi
Copy link
Member Author

xref – #406, #386

@jonpsy
Copy link

jonpsy commented Nov 29, 2023

@jGaboardi Are we sure that the algorithms's functional logic is correct and only the API is outdated? Are there any document/benchmark for when these algorithms were running (before the API got outdated) so we can establish that logic is correct?

Details regarding this (via comment or associated links) would be helpful. Much thanks ~!

@jGaboardi
Copy link
Member Author

Are we sure that the algorithms's functional logic is correct and only the API is outdated?

Nope. I have no idea. As @knaaptime pointed out here, we aren't exactly sure who contributed that. Maybe @sjsrey has a better idea?

Are there any document/benchmark for when these algorithms were running (before the API got outdated) so we can establish that logic is correct?

Another "not sure" here. At least not that I am aware of.

@knaaptime
Copy link
Member

@jonpsy the code was ported from the outdated pysal region module, which itself was a reimplementation of clusterpy, i believe. The algorithm itself should be in good shape, afaik (i actually dont know why the api never got integrated...), but if you want to benchmark it, there's a version of AZP in pygeoda you could test against if you like. The most recent paper i'm aware of that actually uses AZP is this, but apart from that it's not seen often in the wild.

if you want to get the api in working shape, we'd gladly accept a PR :)

@jGaboardi
Copy link
Member Author

we'd gladly accept a PR :)

very gladly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants