Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skyum raises NameError when numba not installed #81

Open
wirrell opened this issue Apr 14, 2022 · 1 comment
Open

skyum raises NameError when numba not installed #81

wirrell opened this issue Apr 14, 2022 · 1 comment

Comments

@wirrell
Copy link

wirrell commented Apr 14, 2022

Calling pointpaths.skyum raises NameError if the user does not have Numba installed. This is caused by a check for Numba in centrography.py on lines 402-405

try:
    from numba import njit, boolean

    HAS_NUMBA = True

which, if the numba import fails, leaves HAS_NUMBA undefined.

Suggested fix: define HAS_NUMBA = False in the except ModuleNotFoundError statement that begins on line 445.

@ljwolf
Copy link
Member

ljwolf commented Apr 14, 2022

Thanks! Will fix. I would also recommend pygeos.minimum_bounding_circle, which did not exist when this implementation of Skyum's algorithm was made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants