Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAS_NUMBA left undefined #70

Open
nathanjmcdougall opened this issue Feb 25, 2021 · 1 comment
Open

HAS_NUMBA left undefined #70

nathanjmcdougall opened this issue Feb 25, 2021 · 1 comment
Milestone

Comments

@nathanjmcdougall
Copy link

nathanjmcdougall commented Feb 25, 2021

In centrography.py, there's a check for if the numba module is available:

try:
    from numba import njit, boolean

    HAS_NUMBA = True

Etc. But if numba isn't installed, then HAS_NUMBA is undefined, which can cause problems when using functions, e.g. minimum_bounding_circle.

I'm not sure, but potentially the fix is as simple as adding HAS_NUMBA = False in the Exception to the above try statement:

except ModuleNotFoundError:

    def njit(func, **kwargs):
        return func
@ljwolf
Copy link
Member

ljwolf commented Feb 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants