Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types in swig input file #174

Open
jamesjer opened this issue Oct 11, 2018 · 1 comment · May be fixed by #433
Open

Incorrect types in swig input file #174

jamesjer opened this issue Oct 11, 2018 · 1 comment · May be fixed by #433

Comments

@jamesjer
Copy link

The agattr_label function is declared to return int, but it should return Agsym_t * instead. Also, the second parameter of agidnode and the fourth parameter of agidedge should have type IDTYPE, rather than unsigned long (which may or may not be the same type as IDTYPE).
@jarrodmillman jarrodmillman added this to the 1.7 milestone Aug 9, 2020
@jarrodmillman jarrodmillman modified the milestones: 1.7, 1.8 Feb 1, 2021
@jarrodmillman jarrodmillman modified the milestones: 1.8, 1.9, 1.10 Feb 9, 2022
@dschult
Copy link
Contributor

dschult commented Aug 17, 2022

It looks like the return type of agattr_label has been corrected to Agsym_t *.
The impact of setting the type of the parameters mentioned above to IDTYPE is not clear to me. In cgraph.h IDTYPE is currently set to be uint64_t. I guess this change would ensure that pygraphviz would include any potential future change in that type.

If someone wants to try this change, it would occur at lines 153 and 166 of graphviz.i and would change unsigned long to IDTYPE.

@rossbar rossbar linked a pull request Aug 18, 2022 that will close this issue
Open
@jarrodmillman jarrodmillman modified the milestones: 1.10, 1.11 Aug 20, 2022
@jarrodmillman jarrodmillman modified the milestones: 1.11, 1.12 May 31, 2023
@jarrodmillman jarrodmillman removed this from the 1.12 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update type of id param to IDTYPE in swig wrapper. rossbar/pygraphviz
3 participants
@jarrodmillman @dschult @jamesjer