1.9: several issues with what is installed

[kloczek]

Looks like examples, pygraphviz/tests and INSTALL.txt are installed.
Part of the problems with pytest is installing pygraphviz/tests which creates kind of conditions to pass pytest.
I just found that in fedora spec file as workround to pass tests has been used hack to pass path to installed resources

%check
pytest -v %{buildroot}%{python3_sitearch}/pygraphviz/tests/

[rossbar]

I don't understand the issue, would you mind expanding on the OP a bit? Installing with the test suite is intentional (AFAIK) so that the installation is testable after install. This is particularly important for pygraphviz since it currently builds/links against the local graphviz installation. The standard way to run the test suite for the installed pygraphviz would be something like pytest --pyargs pygraphviz in whichever environment pygraphviz is installed, but it doesn't sound like this is the issue...

[kloczek]

I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.

• python3 -sBm build -w --no-isolation
• because I'm calling build with --no-isolation I'm using during all processes only locally installed modules
• install .whl file in </install/prefix>
• run pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix>

Please check what is in generated .whl file and testing using above methodology.
If testing requires --pyargs pygraphviz that should be added in pytest.ini.

[rossbar]

If testing requires --pyargs pygraphviz that should be added in pytest.ini.

I'm not sure what would be added to the config file... pytest --pyargs is the canonical incantation for running the test suite on installed libraries. I'm not a pytest expert though, so if there's a specific chunk of pytest documentation that you base your workflow on, please link it here so we can take a look!

[kloczek]

https://docs.pytest.org/en/6.2.x/example/pythoncollection.html#interpreting-cmdline-arguments-as-python-packages

[rossbar]

I'm -0.5 on making --pyargs a default flag for pytest as I feel this has the potential to introduce complications for the development workflow. For example, if a developer is using pip install . without the developer/editable mode, then modifying this flag may subtly change the behavior of pytest in their dev env. Then again, I'm clearly biased towards developers ;) - if others prefer modifying the defaults I don't feel very strongly about it!