fix validation of ints with leading unary minus #1291
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1291 will not alter performanceComparing Summary
|
|
Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Pydantic throws a validation error when parsing the negative integer strings. Here's the issue pydantic/pydantic#9396.
I updated the strip_leading_zeros function to handle a leading unary minus character, ensuring it does not throw an error if the string begins with a minus sign.
Related issue number
fix pydantic/pydantic#9396
Checklist
pydantic-core(except for expected changes)Selected Reviewer @sydney-runkle
As a beginner in Rust, this is my first attempt at contributing to Pydantic. :)
Selected Reviewer: @samuelcolvin