You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PatchCollectionABC (and also CoordinatePatchCollection) has an .extract() method that doesn't appear to be used---the contents of extract() are more-or-less reproduced inside find_stars_and_average. I'm betting either find_stars_and_average should use extract, or extract should be removed as un-used.
If you keep .extract(), the test test_coordinate_patch_collection_extraction_many_coordinates in test_fitter.py generates warnings (from inside PatchCollectionABC.add()) because duplicate coordinates are generated for the test case. Those can be silenced by de-duplicating the generated coordinates by adding coords = list(set(coords)) at the start of the test function (or maybe there's a cleaner way by adjusting how hypothesis generates the coordinates).
The text was updated successfully, but these errors were encountered:
I believe extract is a vestigial function that lingers after the more helpful find_stars_and_average was developed. Originally, I was extracting patches based on a stellar catalog instead of SEP. It might be nice for find_stars_and_average to use extract. I've been hoping to decrease the complexity of find_stars_and_average anyway; it's on the long side of functions at 100+ lines. Maybe we can modularize its functionality some by using extract?
Anyway, thanks for raising this. I can look into it after the PUNCH review next week.
PatchCollectionABC
(and alsoCoordinatePatchCollection
) has an.extract()
method that doesn't appear to be used---the contents ofextract()
are more-or-less reproduced insidefind_stars_and_average
. I'm betting eitherfind_stars_and_average
should useextract
, orextract
should be removed as un-used.If you keep
.extract()
, the testtest_coordinate_patch_collection_extraction_many_coordinates
intest_fitter.py
generates warnings (from insidePatchCollectionABC.add()
) because duplicate coordinates are generated for the test case. Those can be silenced by de-duplicating the generated coordinates by addingcoords = list(set(coords))
at the start of the test function (or maybe there's a cleaner way by adjusting howhypothesis
generates the coordinates).The text was updated successfully, but these errors were encountered: