Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BiphasicPulseTrain metadata #435

Open
jgranley opened this issue Nov 22, 2021 · 0 comments
Open

[ENH] BiphasicPulseTrain metadata #435

jgranley opened this issue Nov 22, 2021 · 0 comments

Comments

@jgranley
Copy link
Member

jgranley commented Nov 22, 2021

Currently, manipulating BiphasicPulseTrains results in unexpected behavior when using with a BiphasicAxonMapModel. During creation, the amplitude, frequency, and pulse duration are stored in metadata, and are later used in the BiphasicAxonMapModel. If pulse train is modified in any way (e.g. multiplying by a scaler to scale amplitude), the metadata is unchanged, and the model will predict the same thing.

If this were updated, then ImageStimulus would be able to be used with amplitude encoding

Describe the solution you'd like
Modifying a BiphasicPulseTrain should either update the metadata if the resulting pulse is still a valid BiphasicPulseTrain, or it should somehow mark in the metadata that this is no longer a valid BiphasicPulseTrain so that the Biphasic model will reject the stimulus. The overloaded operaters will have to be overridden for BiphasicPulseTrain, and perhaps some metadata changes.

@jgranley jgranley self-assigned this Nov 22, 2021
@jgranley jgranley changed the title BiphasicPulseTrain metadata [ENH] BiphasicPulseTrain metadata Nov 22, 2021
@mbeyeler mbeyeler added this to the v0.8 milestone Nov 24, 2021
@jgranley jgranley removed their assignment Mar 3, 2022
@mbeyeler mbeyeler modified the milestones: v0.8, v0.9 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants