Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronto does not raise error when removing blank line from between methods #69

Open
mariusz-blaszczak opened this issue Mar 1, 2021 · 1 comment

Comments

@mariusz-blaszczak
Copy link

mariusz-blaszczak commented Mar 1, 2021

I found following issue:

Steps to recreate

  1. clone repo https://github.com/mariusz-blaszczak/recreate_error_in_pronto_rubocop
  2. bundle install
  3. rubocop main.rb - raises 0 errors
  4. git checkout -b test
  5. Modify file main.rb: remove empty line between methods foo and bar
  6. rubocop main.rb - raises Use empty lines between method definitions
  7. pronto run - does not raise error

Expected

Pronto should raise error Use empty lines between method definitions

Actual

No error from pronto

Additional info

Tested with ruby 2.7.0p0

@M-Yamashita01
Copy link
Contributor

We tried the same procedure and the error was not detected.

Looking to Pronto, pronto run is detected error for committed changes.
Because the procedure is not included the commit command for the changes, we think that the error was not detected.
If we run pronto run --unstaged, the error seems to be detected.

We will be happy if we can be of any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants