Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8: Implement support in Ruby client library #306

Open
4 tasks
Tracked by #13095
ywwg opened this issue Mar 5, 2024 · 5 comments
Open
4 tasks
Tracked by #13095

UTF-8: Implement support in Ruby client library #306

ywwg opened this issue Mar 5, 2024 · 5 comments

Comments

@ywwg
Copy link

ywwg commented Mar 5, 2024

As in prometheus/client_golang#1369 and prometheus/client_java#916, the Ruby client library needs to be updated to support UTF-8.

Tasks:

  • Add flag to enable change in validation logic to check that metric and label names are UTF-8 valid instead of the old letters/numbers/underscores/colons set
  • Update exposition format parsers for the new syntax
  • Update PromQL parsers (if any) for the new syntax
  • Update content negotiation logic

For background and references see prometheus/prometheus#13095

@Sinjo
Copy link
Member

Sinjo commented Mar 5, 2024

Hey, thanks for the heads up. I've got a rough idea in my head of how those changes will fit into the codebase.

I've given the proposal a read and one thing that stuck out to me is that grouping key labels in the pushgateway client's code aren't mentioned. Are they sticking to the old rules for now?

@beorn7
Copy link
Member

beorn7 commented Mar 5, 2024

Very good point. We haven't thought about PGW yet.
That needs more code changes, and some more ideas. sigh

@beorn7
Copy link
Member

beorn7 commented Mar 5, 2024

For now, I would assume the PGW doesn't support the new UTF-8 names yet.

@ywwg
Copy link
Author

ywwg commented Mar 5, 2024

We are making a note to create a design for this situation

@Sinjo
Copy link
Member

Sinjo commented Mar 5, 2024

That needs more code changes, and some more ideas. sigh

Happy to be of service 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants