Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement native histograms support #286

Open
GiedriusS opened this issue Apr 19, 2023 · 4 comments
Open

Implement native histograms support #286

GiedriusS opened this issue Apr 19, 2023 · 4 comments
Labels
breaking-change Issues/PRs that break API and require a major version release

Comments

@GiedriusS
Copy link

Would be cool to have this.

@Sinjo
Copy link
Member

Sinjo commented Apr 19, 2023

Definitely on our radar! Can't promise when we'll get to it, as most development happens in our spare time now, but definitely something we want to implement.

@pcasaretto

This comment was marked as outdated.

@Sinjo Sinjo added the breaking-change Issues/PRs that break API and require a major version release label Dec 26, 2023
@csmarchbanks
Copy link
Member

👋 I am looking at supporting native histograms in client_python, which requires adding a native histogram representation in the text format. If you all are interested in using the text format for client_ruby support as well I created a design doc to go over some text format options here: https://docs.google.com/document/d/1qoHf24cKMpa1QHskIjgzyf3oFhIPvacyJj8Tbe6fIrY/edit#heading=h.5sybau7waq2q.

Any comments are welcome!

@Sinjo
Copy link
Member

Sinjo commented Feb 4, 2024

@csmarchbanks Hey! Sorry for not getting back to you sooner. That does look interesting to me.

It looks like you've got broad support for option 1 in that doc, and the reasoning behind it makes sense to me too. We don't have the same restriction of no dependencies here in client_ruby, but it happens that we don't have any currently (aside from development dependencies).

Unrelated to the exposition format, we will need to figure out the storage side of native histograms in this client. I'm not sure if our existing data store interface will be able to support this in a non-breaking way. That's not essential though - it just informs whether we cut a minor or major release for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issues/PRs that break API and require a major version release
Projects
None yet
Development

No branches or pull requests

4 participants