Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the role of proposal dummy values #14

Open
marcoct opened this issue Mar 5, 2021 · 1 comment
Open

Document the role of proposal dummy values #14

marcoct opened this issue Mar 5, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@marcoct
Copy link
Contributor

marcoct commented Mar 5, 2021

This text implies that ProposalDummyValues are only used for distributions that have infinite (and discrete) support:

https://github.com/probcomp/PClean/blob/master/src/distributions/distributions.jl#L10-L14

But StringPrior has finite support (there is a maximum length), and it implements discrete_proposal_dummy_value:

https://github.com/probcomp/PClean/blob/master/src/distributions/string_prior.jl#L23-L25

@alex-lew
Copy link
Contributor

alex-lew commented Mar 6, 2021

Good question -- it's really for support that's too large to tractably enumerate, not just infinite support. It is used whenever preferred values are used (it's the "other" token from the PClean paper).

@marcoct marcoct changed the title Why does StringPrior use ProposalDummyValue? Document the role of ProposedDummyValue Mar 6, 2021
@marcoct marcoct changed the title Document the role of ProposedDummyValue Document the role of proposal dummy values Mar 6, 2021
@alex-lew alex-lew added the documentation Improvements or additions to documentation label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants