Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webapp to independent module or repo #22741

Closed
elharo opened this issue May 14, 2024 · 0 comments · Fixed by #22745
Closed

Move webapp to independent module or repo #22741

elharo opened this issue May 14, 2024 · 0 comments · Fixed by #22745
Assignees
Labels

Comments

@elharo
Copy link
Contributor

elharo commented May 14, 2024

The Node based JavaScript console that is generated into

presto-main/src/main/resources/webapp/

seems mostly independent of the rest of the code base. Its build system is a hack that shells out from maven to download nodejs and use yarn. This doesn't integrate well into all CI systems because different tools than normal download code from locations other than the Maven repository system. This can be more or less painful depending on how firewalls and proxies are configured. Exactly what problems any given developer will have where depends on their local environment. (We already know this caused different problems for two different groups of developers when #22645 was merged.)

Assuming we can't rewrite this so it's all just Java+Maven, consider moving this into a separate module or repo. That is, ./mvnw clean install no longer builds any of this. It can have a completely separate build that might not even use Maven and instead go straight to nodejs and yarn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants