Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for existing github repository always fails if the repository is private #78

Open
preslavmihaylov opened this issue Oct 24, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@preslavmihaylov
Copy link
Owner

In #70, a new validation was added which first checks that a repository exists before proceeding with the rest of the application.

For private github repositories, this always fails because the apitoken is not acquired before making the validation.
What's more, the API token is not added as an authorisation middleware when checking that the repository exists.

What to do about it:

  • Acquire Authentication token before making any validations
  • Instrument calls to IsHealthy in fetcher to plug in the authorisation middleware
@preslavmihaylov
Copy link
Owner Author

This issue also makes this warning:
image

always visible as it checks for the existence of the token, without acquiring it first

@preslavmihaylov preslavmihaylov added the bug Something isn't working label Oct 24, 2020
@preslavmihaylov
Copy link
Owner Author

No need to create a new release after this is fixed as these changes are done after the latest release (#68)

@preslavmihaylov
Copy link
Owner Author

I've mitigated this incident, but I had to remove the #70 validation. In a follow-up PR, I will introduce it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant