Git Gui Error: explorer.exe not found in PATH #4356

deanwiles · 2023-03-21T14:57:39Z

I was not able to find an open or closed issue matching what I'm seeing

Setup

Which version of Git for Windows are you using? Is it 32-bit or 64-bit? 64-bit

$ git --version --build-options

git version 2.40.0.windows.1
cpu: x86_64
built from commit: 1d90ca2906dd4b7ddaf0669a13c173ec579d794a
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit? 64-bit

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.19045.2728]

What options did you set as part of the installation? Or did you choose the
defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
> type "$env:USERPROFILE\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

type "C:\Program Files\Git\etc\install-options.txt"
Editor Option: Notepad++
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled

Any other interesting things about your environment that might be related
to the issue you're seeing?

I have reproduced this error on multiple PCs running Windows 10, 64-bit Git Gui.
The error was first noticed in Git version 2.39.1 and later versions (2.39.2, 2.40.0), but worked correctly in Git version 2.38.1. (I have not tried other 2.38.x versions to see exactly when it started.)

Details

Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Git Gui

What commands did you run to trigger this issue? If you can provide a
Minimal, Complete, and Verifiable example
this will help us understand the issue.

1. Launch Git Gui
2. Open an existing repository
3. From the Menu bar, select Repository > Explore Working Copy

What did you expect to occur after running these commands?

Windows Explorer used to open showing the repository root directory and files.

What actually happened instead?

This error dialog was displayed:

Expanding the Details>> shows:

If the problem was occurring with a specific repository, can you provide the
URL to that repository to help us with testing?

Error occurs with multiple repositories.

The text was updated successfully, but these errors were encountered:

Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes git-for-windows/git#4356 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes git-for-windows#4356 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho · 2023-03-21T15:28:38Z

@deanwiles could you edit C:\Program Files\Git\mingw64\libexec\git-core\git-gui.tcl (with elevated privileges) and make the changes corresponding to https://github.com/git-for-windows/git/pull/4357/files, then verify that it fixes the problem for you?

Hattes · 2023-03-21T21:27:10Z

I had the same issue, and the suggested fix worked for me.

This is a companion PR of prati0100/git-gui#95 Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes #4356

dscho · 2023-03-21T21:39:24Z

/add relnote bug Git GUI's Repository>Explore Working Copy was broken since v2.39.1, which has been fixed.

The workflow run was started

Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes #4356 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

This is a companion PR of prati0100/git-gui#95 Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes #4356

Git GUI's `Repository>Explore Working Copy` [was broken since v2.39.1](git-for-windows/git#4356), which has been fixed. Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>