Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting lazer scores loses indication of whether it is failed #27865

Open
frenzibyte opened this issue Apr 14, 2024 · 1 comment
Open

Exporting lazer scores loses indication of whether it is failed #27865

frenzibyte opened this issue Apr 14, 2024 · 1 comment
Assignees

Comments

@frenzibyte
Copy link
Member

Part of #27765. It seems easy to support this by including a Passed boolean state inside the LegacyReplaySoloScoreInfo bundle and read it on decode. Opening an issue thread in case this requires further discussion. If no discussion needed, I will proceed with a PR.

@frenzibyte
Copy link
Member Author

To clarify the confusion of this issue thread contradicting with #27864, the proposed Passed state that is to be defined in LegacyReplaySoloScoreInfo is not meant to be related to ScoreInfo.Passed and is foreseen to be set based on whether the score's rank is not F.

After discussing in discord, we concluded that LegacyReplaySoloScoreInfo should rather store the score's overall rank instead of my original proposal above (Passed boolean state indicating whether it's an F or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant