Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out legacy skin config interaction with ISerialisableDrawable #27791

Open
smoogipoo opened this issue Apr 4, 2024 · 0 comments
Open

Figure out legacy skin config interaction with ISerialisableDrawable #27791

smoogipoo opened this issue Apr 4, 2024 · 0 comments
Assignees
@smoogipoo
Labels
area:skinning

Comments

@smoogipoo
Copy link
Contributor

Skinning for ruleset components is added in #27773. It works fine for new components, however it cannot currently interact with the legacy skin config due to:

  1. Read-only bindables being provided via skin.GetConfig<>.
  2. The bindables not actually being hooked up to the config. Even if we get around (1) by casting them to Bindable<> and change their value, it won't be stored to the config.
  3. We don't have a legacy encoder.
@smoogipoo smoogipoo self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smoogipoo smoogipoo

Labels
area:skinning
Projects
osu! client development focus
Status: Needs implementation
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smoogipoo