Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio or metronome goes off-sync when changing playback speed in editor #27727

Open
c-sig opened this issue Mar 25, 2024 · 10 comments
Open

audio or metronome goes off-sync when changing playback speed in editor #27727

c-sig opened this issue Mar 25, 2024 · 10 comments
Labels
area:editor audio priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@c-sig
Copy link

c-sig commented Mar 25, 2024

Type

Game behaviour

Bug description

waveform should be consistently in sync with the sound heard regardless of playback speed

Screenshots or videos

bug.mp4

Version

2024.312.1-lazer

Logs

compressed-logs.zip

@longnguyen2004
Copy link

This delay only happens when playback is started right at a metronome tick, it doesn't happen during normal playback.

@tybug
Copy link
Member

tybug commented Mar 25, 2024

Can you provide some timestamps or exact descriptions of what you expect to happen? Are you just pointing out that when changing playback speed (e.g. at 0:52), the current position in the timeline jumps, when you expect it to remain stationary?

@Gabixel
Copy link
Contributor

Gabixel commented Mar 26, 2024

I don't want to be wrong (since it took me a while to understand too) @tybug, but I think he's referring to the fact that the editor "tick" sound is not synced (to the "tick" sound in his audio track) if the playback speed changes / is low (or vice-versa: the track is off-sync when it's slowed down?).
I think I can hear the different distance between the two "tick"s when the track speed changes, but it's very subtle.

@bdach
Copy link
Collaborator

bdach commented Mar 26, 2024

#26707 probably fixes this but has unresolved reviews.

@c-sig
Copy link
Author

c-sig commented Mar 26, 2024

I think I can hear the different distance between the two "tick"s when the track speed changes, but it's very subtle.

specifically talking about this

though

current position in the timeline jumps, when you expect it to remain stationary?

might be related but not really my main concern

@bdach
Copy link
Collaborator

bdach commented Mar 26, 2024

I'm gonna tentatively close this with the hopes that #26707 is indeed the fix here. If that turns out to be wrong please report back after next release and we'll reopen.

@bdach bdach closed this as completed Mar 26, 2024
@c-sig
Copy link
Author

c-sig commented Apr 13, 2024

a.mp4

still the case in 2024.412.1-lazer

@Joehuu Joehuu reopened this Apr 13, 2024
@peppy
Copy link
Sponsor Member

peppy commented Apr 15, 2024

This is likely going to be caused by what is explained in #27826.

Basically the point of reference for adjusting offsets when rate adjusts are involved is currently incorrect (the "visual" waveform offset is not baked in to the base timing values).

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Apr 15, 2024
@Walavouchey
Copy link
Member

@ppy/team-client since this was reopened

@peppy
Copy link
Sponsor Member

peppy commented Apr 15, 2024

a bit late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor audio priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

9 participants