-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audio or metronome goes off-sync when changing playback speed in editor #27727
Comments
This delay only happens when playback is started right at a metronome tick, it doesn't happen during normal playback. |
Can you provide some timestamps or exact descriptions of what you expect to happen? Are you just pointing out that when changing playback speed (e.g. at 0:52), the current position in the timeline jumps, when you expect it to remain stationary? |
I don't want to be wrong (since it took me a while to understand too) @tybug, but I think he's referring to the fact that the editor "tick" sound is not synced (to the "tick" sound in his audio track) if the playback speed changes / is low (or vice-versa: the track is off-sync when it's slowed down?). |
#26707 probably fixes this but has unresolved reviews. |
specifically talking about this though
might be related but not really my main concern |
I'm gonna tentatively close this with the hopes that #26707 is indeed the fix here. If that turns out to be wrong please report back after next release and we'll reopen. |
a.mp4still the case in 2024.412.1-lazer |
This is likely going to be caused by what is explained in #27826. Basically the point of reference for adjusting offsets when rate adjusts are involved is currently incorrect (the "visual" waveform offset is not baked in to the base timing values). |
@ppy/team-client since this was reopened |
a bit late |
Type
Game behaviour
Bug description
waveform should be consistently in sync with the sound heard regardless of playback speed
Screenshots or videos
bug.mp4
Version
2024.312.1-lazer
Logs
compressed-logs.zip
The text was updated successfully, but these errors were encountered: