Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiling] Sidebar bar does not respond to width of the Settings Window #253

Closed
senntore opened this issue Apr 30, 2024 · 7 comments
Closed
Milestone

Comments

@senntore
Copy link

Unlike other Cosmic apps, the sidebar in the Settings app does not hide automatically when we make the width of the window smaller.
Screenshot:
screenshot-2024-04-30-10-33-45

@edfloreshz
Copy link
Contributor

I cannot replicate this, when I reduce the width it hides the sidebar.

image

@senntore
Copy link
Author

senntore commented May 6, 2024

That's strange. I've this issue on version 0.1.0~1714937562~22.04~a544fed of Cosmic Settings.
Here is a recording:
settings_sidebar.webm

@git-f0x
Copy link
Contributor

git-f0x commented May 11, 2024

I believe this is exclusive to tiling.

@senntore
Copy link
Author

Oh, that explains why @edfloreshz might not have this issue.
Testing again, I found even more issues with the UI in the Settings app.

In floating mode, decrease the width of Settings window to have just the sidebar. If we enter to tiling mode now, the Settings app behave very strangely. As the sidebar does not go back to it's usual state when the width is more than the minimum required for it.

@WatchMkr WatchMkr changed the title Sidebar bar does not respond to width of the Settings Window [Tiling] Sidebar bar does not respond to width of the Settings Window May 17, 2024
@WatchMkr
Copy link

Nice catch. So we have two bugs that can be reproduced with:

  1. Tile COSMIC Settings and COSMIC Files > Resize windows > Files collapses to the window content, Settings does not
  2. Float COSMIC Setting and reduce to a single column. Tile the workspace. The NavBar extended to the entire window width.

@WatchMkr WatchMkr added this to the alpha 1 milestone May 17, 2024
@mmstick
Copy link
Member

mmstick commented May 30, 2024

Ready to review with commit 4ceac69

@senntore
Copy link
Author

Yes, these two issues are fixed now. You can close it after testing it in your end.

@mmstick mmstick closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Alpha 1 Complete
Development

No branches or pull requests

5 participants