Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop > Appearance > Accent Color: Automatic mode that matches color from desktop bg #204

Open
ryanabx opened this issue Mar 19, 2024 · 7 comments

Comments

@ryanabx
Copy link
Contributor

ryanabx commented Mar 19, 2024

This is just an idea, but having the accent color be chosen automatically by the background would be a nice addition.

In the case of outputs/desktops with different backgrounds (as I believe that is a feature), the accent color would have to also be per-desktop/output

@git-f0x
Copy link
Contributor

git-f0x commented Mar 22, 2024

This is planned post-release (i.e. extract theme from wallpaper like Plasma/Material You).

@wash2
Copy link
Contributor

wash2 commented Mar 22, 2024

Ya, I think this could possibly be a toolkit variable and xdp-cosmic could monitor the cosmic-bg state for the current wallpaper to calculate the accent color whenever the state changes or toolkit config variable changes.

@git-f0x
Copy link
Contributor

git-f0x commented Mar 22, 2024

Would be fun for the app theme (not just accent) to change as you move a window between monitors (redish wallpaper on one monitor, greenish on another... party!).
Though probably not feasible in a performant way. 🥲

@ryanabx
Copy link
Contributor Author

ryanabx commented Mar 22, 2024

Would be fun for the app theme (not just accent) to change as you move a window between monitors (redish wallpaper on one monitor, greenish on another... party!).

Though probably not feasible in a performant way. 🥲

Shouldn't affect performance that much if at all, since no one really moves windows between monitors multiple times a second

@git-f0x
Copy link
Contributor

git-f0x commented Mar 22, 2024

since no one really moves windows between monitors multiple times a second

Well now I have an urge to do just that!

On a more serious note, I would imagine that theme changes would apply on window drop (though that might feel a bit weird). Not sure if it's possible to apply live while the window is being dragged (but would look really cool).

@wash2
Copy link
Contributor

wash2 commented Mar 22, 2024

Would be fun for the app theme (not just accent) to change as you move a window between monitors (redish wallpaper on one monitor, greenish on another... party!). Though probably not feasible in a performant way. 🥲

I think this may be difficult to implement as the theme is not customizable per-monitor 😅

@git-f0x
Copy link
Contributor

git-f0x commented Mar 23, 2024

That might be cool to have as a very long-term option (COSMIC 2, 3... since wallpapers per monitor and theme generation are planned).
E.g. when the switch for auto theme generation is on, each monitor gets assigned its own theme based on its wallpaper, and that theme is applied to apps dropped onto the monitor.
Though it might feel weird in practice, but not sure how to handle different wallpapers on monitors and theme generation (which wallpaper to choose?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants