Issue with adding attachment with same name

[libin-math]

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/js-advanced-commenting

Contributor(s)

@a1mery , @wideserg , @sudharsank

What happened?

While adding an attachment to the commenting box, if the attachment name already exist in the library path, the system will go in to indefinite loading spinner.

Steps to reproduce

1. upload an image to the comment box
2. re-upload the same image in the comment box

Expected behavior

the filename should be renamed with the file_id while storing in the library, and the file with same file_id need to be fetched to display in the commenting box and this could potential solve the issue.

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

• Internet Explorer
• Microsoft Edge
• Google Chrome
• FireFox
• Safari
• mobile (iOS/iPadOS)
• mobile (Android)
• not applicable
• other (enter in the "Additional environment details" area below)

What version of Node.js is currently installed on your workstation?

Compactable

What version of Node.js is required by the sample?

Compactable

Paste the results of SPFx doctor

Nil

Additional environment details

nil