Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain textures disappear #5806

Open
SomenameIchose opened this issue Mar 24, 2024 · 12 comments · May be fixed by #5829
Open

Terrain textures disappear #5806

SomenameIchose opened this issue Mar 24, 2024 · 12 comments · May be fixed by #5829

Comments

@SomenameIchose
Copy link

Observed behaviour

When approaching the planet at a certain distance some terrain textures disappear.
On a first screenshot textures are proper
screenshot-20240324-215601
But at some point they(textures) start bugging like this
screenshot-20240324-215625
screenshot-20240324-215536
screenshot-20240324-215524

Expected behaviour

Terrain textures should be stable and shouldn't disappear

Steps to reproduce

Fly up to critical distance to certain planets and moons (in this case it is Pallas, I also saw this bug approaching Thebe)

My pioneer version (and OS):
ver 20240314 (8b6ae92)
OS: Windows 10 Home Edition

My output.txt (required) and game save (optional, but recommended)
output.txt
save.zip

@fluffyfreak
Copy link
Contributor

That's not rendering the patch at all it seems, almost like the culling has decided it isn't visible

@fluffyfreak
Copy link
Contributor

I've not been able to repro' this with some quick local testing around Pallas or Thebe. I also tried with the supplied savegame.

@SomenameIchose what GPU do you have?

@SomenameIchose
Copy link
Author

I've not been able to repro' this with some quick local testing around Pallas or Thebe. I also tried with the supplied savegame.

@SomenameIchose what GPU do you have?
Intel(R) Pentium(R) Gold G5420 CPU @ 3.80GHz 3.79 GHz

@SomenameIchose
Copy link
Author

I gave an another try to fly to Pallas but textures don't disappear this time. Maybe it happens at certain coordinates?

@SomenameIchose
Copy link
Author

SomenameIchose commented Mar 26, 2024

Yes, I tested it, they disappear at coordinates of S029°25'12 E042°42'07

@pcercuei
Copy link
Contributor

I can reproduce, see the attached save file. Just load it in Pioneer and you should see it.

Jameson2.zip

@pcercuei
Copy link
Contributor

Note that it happens both on my integrated Intel card and my discrete Nvidia card (with Nouveau).

@fluffyfreak
Copy link
Contributor

This isn't a GPU/driver bug, this is CPU side terrain generation and the rendering calls itself. Can confirm that it's CPU side only so you'll see it on anything that can run it.

@fluffyfreak
Copy link
Contributor

I can confirm that it's the Horizon Culling optimisation which is... over optimising for some reason 🤷 however nothing appears to have changed in the SSphere::HorizonCulling method in years. The only change I can see is to the centroid in GeoPatch but I don't know how that might be affecting it.

@fluffyfreak
Copy link
Contributor

Oof nope that ain't it either, you have found me a real doozy of a bug 🤣

@fluffyfreak
Copy link
Contributor

Ok, I might have a fix for this in the works but it's after midnight, so I'll continue another day

@fluffyfreak fluffyfreak linked a pull request Apr 25, 2024 that will close this issue
@fluffyfreak
Copy link
Contributor

I've put in a first draft of a fix in #5829 which will need some serious testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants