Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: stabilize TestTruncateTableAndSchemaDependence #53245

Merged
merged 1 commit into from
May 14, 2024
Merged

test: stabilize TestTruncateTableAndSchemaDependence #53245

merged 1 commit into from
May 14, 2024

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53244

Problem Summary:

The function OnJobUpdatedExported is invoked during CREATE TABLE instead of TRUNCATE TABLE.

What changed and how does it work?

Add a check in OnJobUpdatedExported.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 14, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

/check-issue-triage-complete

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5621%. Comparing base (4b91fee) to head (23258f0).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53245        +/-   ##
================================================
+ Coverage   74.4490%   74.5621%   +0.1131%     
================================================
  Files          1493       1493                
  Lines        356315     429636     +73321     
================================================
+ Hits         265273     320346     +55073     
- Misses        71770      89400     +17630     
- Partials      19272      19890       +618
Flag Coverage Δ
integration 49.0915% <ø> (?)
unit 71.2654% <ø> (-1.9514%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.4617% <ø> (+7.4705%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 06:08:54.316122537 +0000 UTC m=+1547088.073258111: ☑️ agreed by zimulala.
  • 2024-05-14 07:07:18.491548503 +0000 UTC m=+1550592.248684076: ☑️ agreed by ywqzzy.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 39383e3 into pingcap:master May 14, 2024
23 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@tangenta @terry1purcell
test: stabilize TestTruncateTableAndSchemaDependence (pingcap#53245)
9146130 
close pingcap#53244
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@tangenta @RidRisR
test: stabilize TestTruncateTableAndSchemaDependence (pingcap#53245)
589d2b0 
close pingcap#53244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test TestTruncateTableAndSchemaDependence
4 participants
@tangenta @hawkingrei @zimulala @ywqzzy