Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to execute SQL, but succeed in mysql:v8.0 #53236

Closed
joccau opened this issue May 13, 2024 · 2 comments · Fixed by #53268
Closed

Failed to execute SQL, but succeed in mysql:v8.0 #53236

joccau opened this issue May 13, 2024 · 2 comments · Fixed by #53268
Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.1 compatibility-mysql8 This is a compatibility issue with MySQL 8.0(but NOT 5.7) severity/major sig/planner SIG: Planner type/bug This issue is a bug.

Comments

@joccau
Copy link
Member

joccau commented May 13, 2024

Bug Report

  1. there are 2 tables in database test.
  2. The query SQL is executed successfully at mysql:8.0.37 and TiDB:v7.1.0, but failed to execute SQL at TiDB:v7.5.0.
  3. the error is below when execute SQL at TiDB:v7.5.0

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@joccau joccau added type/bug This issue is a bug. severity/critical compatibility-mysql8 This is a compatibility issue with MySQL 8.0(but NOT 5.7) affects-7.5 labels May 13, 2024
@joccau joccau changed the title Failed to execute SQL, but succeed in mysql Failed to execute SQL, but succeed in mysql:v8.0 May 13, 2024
@lcwangchao
Copy link
Collaborator

A more simple way to reproduce this bug:

create table t1(id int primary key, a varchar(128));
create table t2(id int primary key, b varchar(128), c varchar(128));
UPDATE
    t1
SET
    t1.a = IFNULL(
            (
                SELECT
                    t2.c
                FROM
                    t2
                WHERE
                    t2.b = t1.a
                ORDER BY
                    t2.b DESC,
                    t2.c DESC
                LIMIT
                    1
            ), ''
        )
WHERE
    t1.id = 1;

@lcwangchao lcwangchao added the sig/planner SIG: Planner label May 14, 2024
@lcwangchao
Copy link
Collaborator

image

Seems the UniqueID are not same for schema and column. Stack:

Can't find column test.t2.c in schema Column: [test.t1.id,test.t1.a,test.t2.c] Unique key: []
github.com/pingcap/tidb/pkg/expression.(*Column).resolveIndices
	/Users/wangchao/Code/pingcap/tidb/pkg/expression/column.go:545
github.com/pingcap/tidb/pkg/expression.(*ScalarFunction).resolveIndices
	/Users/wangchao/Code/pingcap/tidb/pkg/expression/scalar_function.go:626
github.com/pingcap/tidb/pkg/expression.(*ScalarFunction).ResolveIndices
	/Users/wangchao/Code/pingcap/tidb/pkg/expression/scalar_function.go:620
github.com/pingcap/tidb/pkg/planner/core.(*Update).ResolveIndices
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/core/resolve_indices.go:825
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildUpdate
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:6101
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).Build
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/core/planbuilder.go:863
github.com/pingcap/tidb/pkg/planner.buildLogicalPlan
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/optimize.go:577
github.com/pingcap/tidb/pkg/planner.optimize
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/optimize.go:495
github.com/pingcap/tidb/pkg/planner.Optimize
	/Users/wangchao/Code/pingcap/tidb/pkg/planner/optimize.go:353
github.com/pingcap/tidb/pkg/executor.(*Compiler).Compile
	/Users/wangchao/Code/pingcap/tidb/pkg/executor/compiler.go:98
github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
	/Users/wangchao/Code/pingcap/tidb/pkg/session/session.go:2211
github.com/pingcap/tidb/pkg/server.(*TiDBContext).ExecuteStmt
	/Users/wangchao/Code/pingcap/tidb/pkg/server/driver_tidb.go:292
github.com/pingcap/tidb/pkg/server.(*clientConn).handleStmt
	/Users/wangchao/Code/pingcap/tidb/pkg/server/conn.go:2010
github.com/pingcap/tidb/pkg/server.(*clientConn).handleQuery
	/Users/wangchao/Code/pingcap/tidb/pkg/server/conn.go:1801
github.com/pingcap/tidb/pkg/server.(*clientConn).dispatch
	/Users/wangchao/Code/pingcap/tidb/pkg/server/conn.go:1288
github.com/pingcap/tidb/pkg/server.(*clientConn).Run
	/Users/wangchao/Code/pingcap/tidb/pkg/server/conn.go:1067
github.com/pingcap/tidb/pkg/server.(*Server).onConn
	/Users/wangchao/Code/pingcap/tidb/pkg/server/server.go:700
runtime.goexit
	/Users/wangchao/.gvm/gos/go1.21.0/src/runtime/asm_arm64.s:1197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.1 compatibility-mysql8 This is a compatibility issue with MySQL 8.0(but NOT 5.7) severity/major sig/planner SIG: Planner type/bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants