Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix issue of doesn't fast fail request when no available connections #53247

Merged
merged 2 commits into from
May 14, 2024
Merged

*: fix issue of doesn't fast fail request when no available connections #53247

merged 2 commits into from
May 14, 2024

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53222
Related PR: tikv/client-go#1339

Problem Summary: fix issue of doesn't fast fail request when no available connections

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
*: fix issue of doesn't fast fail request when no available connections
afd6f35 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
make bazel_prepare
baf1035 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 14, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 06:25:05.829325709 +0000 UTC m=+1548059.586461283: ☑️ agreed by MyonKeminta.
  • 2024-05-14 06:25:48.040572143 +0000 UTC m=+1548101.797707715: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.3963%. Comparing base (4b91fee) to head (baf1035).

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53247        +/-   ##
================================================
- Coverage   74.4459%   67.3963%   -7.0496%     
================================================
  Files          1493       1493                
  Lines        356315     426866     +70551     
================================================
+ Hits         265262     287692     +22430     
- Misses        71778     119310     +47532     
- Partials      19275      19864       +589
Flag Coverage Δ
integration 28.6463% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.2971% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2582% <ø> (+3.2669%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 041f700 into pingcap:master May 14, 2024
22 of 23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#53247
f151e1a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53249.

@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
13 tasks
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
@crazycs520
Revert "This is an automated cherry-pick of pingcap#53247"
a3d20f4 
This reverts commit f151e1a.
ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2024
@ti-chi-bot
*: fix issue of doesn't fast fail request when no available connectio…
c560753 
…ns (#53247) (#53249)

close #53222
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@crazycs520 @terry1purcell
*: fix issue of doesn't fast fail request when no available connectio…
6f5bc2c 
…ns (pingcap#53247)

close pingcap#53222
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@crazycs520 @RidRisR
*: fix issue of doesn't fast fail request when no available connectio…
6a84de6 
…ns (pingcap#53247)

close pingcap#53222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.1 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many failed slow query during TiKV graceful shutdown
4 participants
@crazycs520 @cfzjywxk @ti-chi-bot @MyonKeminta