-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure, that a select interruped by a signal is retried #1121
Conversation
…timeout and false error)
…l is received, while we are in the signal handler
Alright, I think the PR is now in a merge ready state |
Thanks for Your attempt to fix it. Very likelly we will use another approach. The main problem is in misleading AbstractIO::select() result and wrong exception, not the fact it was interrupted. |
Hmm - so it is supposed to be interrupted? We have an AMQP worker on k8s - when the sigterm comes, it's supposed to finish the last message when the sigterm comes, while it's waiting for the pending acks for follow up queues, AMQP will throw an error and the message will be reprocessed What would the approach here then be? |
Thanks for the constructive feedback! Hope that helps :) Best, |
Just noticed what you mean - the error_handler does already catch the interrupt, but does ignore it Thus I'll close this PR If you want I can create a PR for throwing the correct error within the error_handler |
Fixes #1094 and #1118