Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Missing META.json Field if it was not required at time of Release #57

Open
theory opened this issue Feb 22, 2017 · 0 comments
Open
Assignees
Labels
Milestone

Comments

@theory
Copy link
Member

theory commented Feb 22, 2017

When reindexing stuff, I saw a bunch of errors like this:

The italian_fts-1.2.0/META.json file does not adhere to the <a href="http://pgxn.org/spec/">PGXN Meta Specification</a>. Errors:<br/>• Required field /provides: missing [Spec v1.0.0]

It's possible, perhaps likely, that this release and others with this error pre-date the time when /provides was required. Ideally PGXN::Meta::Validator and the related code in the database functions would know this and check the requirements related to the version listed in the META.json file, but it may be that they didn't specify that it was a prerelease version of the spec (the requirement was added in PGXN::Meta::Validator on 2011-06-01T03:51:17 and the spec was updated to v1.0.0 on 0.14.0 2012-01-10T04:10:22Z), so maybe compare the date when reindexing.

@theory theory added the to-do label Feb 22, 2017
@theory theory added this to the v0.17.0 milestone Feb 22, 2017
@theory theory self-assigned this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant