Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApproxInference.query Does not support Weighted Likelihood Sampling dataset ? <discuss> #1716

Open
xy-whu opened this issue Dec 31, 2023 · 1 comment

Comments

@xy-whu
Copy link

xy-whu commented Dec 31, 2023

Subject of the issue

If i first use weighted likelihood sample method to generate a dataset for query, However, ApproxInference.query Does not support Weighted Likelihood Sampled dataset. That is, it ignores all weights.

The docs of ApproxInference.query should be noted, I think.

Your environment

  • pgmpy version
  • Python version
  • Operating System

Steps to reproduce

Tell us how to reproduce this issue. Please provide a minimal reproducible code of
the issue you are facing if possible.

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

@ankurankan
Copy link
Member

@xy-whu Sorry for the late reply and thanks for reporting this. Yes, the docs should clarify this. If you would like please feel free to open a PR fixing this else I will fix it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants