New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicBayesianNetwork limitations #1340
Comments
@nihil21 Yes, I agree with you. DBNs haven't been my main focus as you can see with the number of bugs. But if you would like to contribute something like this, you are most welcome and I think it would be very interesting and useful. |
@ankurankan I can work on this. Could you assign me? |
The code.A DBN with functional loop:
The error:
Issue
pgmpy/pgmpy/models/BayesianNetwork.py Lines 257 to 258 in 6bf4b35
So, whatever the value for Questions
|
@FelipeGiro Are you using the latest The |
My mistake, I forgot one line of code: I did not notice |
@FelipeGiro I looked at this issue and I think if we replace the Bayesian model creation before inference here: https://github.com/pgmpy/pgmpy/blob/dev/pgmpy/inference/base.py#L104 with calls to |
Subject of the issue
From what I've understood, in
pgmpy
it's possible to defineDynamicBayesianNetwork
's edges only in the first time slice (as in #714); so, to define a DBN as the following:I would need to add the edges in the first time slice, like this:
However, by doing so I would create a loop, and thus
pgmpy
throws an error.In my opinion, forcing to define edges in the first time slice is very limiting: functional loops over time are a desired property of DBN, but in this way we lose such property.
The text was updated successfully, but these errors were encountered: