{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":610016408,"defaultBranch":"main","name":"bevy","ownerLogin":"pgavin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-03-05T22:28:36.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1419702?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1678055323.236305","currentOid":""},"activityList":{"items":[{"before":"025e8e639c5443f4c1e0089181d4bb72559022d2","after":"22d605c8df4ad13b773f73fd6eae42ca3ac56fc6","ref":"refs/heads/main","pushedAt":"2024-04-27T18:04:16.000Z","pushType":"push","commitsCount":194,"pusher":{"login":"pgavin","name":"Peter Gavin","path":"/pgavin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1419702?s=80&v=4"},"commit":{"message":"asset throttling: don't be exhausted if there is no limit (#13112)\n\n# Objective\n\n- Since #12622 example `compute_shader_game_of_life` crashes\n```\nthread 'Compute Task Pool (2)' panicked at examples/shader/compute_shader_game_of_life.rs:137:65:\ncalled `Option::unwrap()` on a `None` value\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\nEncountered a panic in system `compute_shader_game_of_life::prepare_bind_group`!\nthread '<unnamed>' panicked at examples/shader/compute_shader_game_of_life.rs:254:34:\nRequested resource compute_shader_game_of_life::GameOfLifeImageBindGroups does not exist in the `World`.\n                Did you forget to add it using `app.insert_resource` / `app.init_resource`?\n                Resources are also implicitly added via `app.add_event`,\n                and can be added by plugins.\nEncountered a panic in system `bevy_render::renderer::render_system`!\n```\n\n## Solution\n\n- `exhausted()` now checks that there is a limit","shortMessageHtmlLink":"asset throttling: don't be exhausted if there is no limit (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2266676348\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bevyengine/bevy/issues/13112\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bevyengine/bevy/pull/13112/hovercard\" href=\"https://github.com/bevyengine/bevy/pull/13112\">bevyengine…</a>"}},{"before":"97fc8001f7203533dca9ed8ed53d62878eee79ca","after":"025e8e639c5443f4c1e0089181d4bb72559022d2","ref":"refs/heads/main","pushedAt":"2024-03-27T03:35:37.000Z","pushType":"push","commitsCount":1941,"pusher":{"login":"pgavin","name":"Peter Gavin","path":"/pgavin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1419702?s=80&v=4"},"commit":{"message":"Fix `Ord` and `PartialOrd` differing for `FloatOrd` and optimize implementation (#12711)\n\n# Objective\n\n- `FloatOrd` currently has a different comparison behavior between its\nderived `PartialOrd` impl and manually implemented `Ord` impl (The\n[`Ord` doc](https://doc.rust-lang.org/std/cmp/trait.Ord.html) says this\nis a logic error). This might be a problem for some `std`\ncontainers/algorithms if they rely on both matching, and a footgun for\nBevy users.\n\n## Solution\n\n- Replace the `PartialEq` and `Ord` impls of `FloatOrd` with some\nequivalent ones producing [better\nassembly.](https://godbolt.org/z/jaWbjnMKx)\n- Manually derive `PartialOrd` with the same behavior as `Ord`,\nimplement the comparison operators.\n- Add some tests.\n\nI first tried using a match-based implementation similar to the\n`PartialOrd` impl [of the\nstd](https://doc.rust-lang.org/src/core/cmp.rs.html#1457) (with added\nNaN ordering) but I couldn't get it to produce non-branching assembly.\nThe current implementation is based on [the one from the `ordered_float`\ncrate](https://github.com/reem/rust-ordered-float/blob/3641f59e314030b2ffa3e6321c0d51f8ce50b385/src/lib.rs#L121),\nadapted since it uses a different ordering. Should this be mentionned\nsomewhere in the code?\n\n---\n\n## Changelog\n\n### Fixed\n\n- `FloatOrd` now uses the same ordering for its `PartialOrd` and `Ord`\nimplementations.\n\n## Migration Guide\n\n- If you were depending on the `PartialOrd` behaviour of `FloatOrd`, it\nhas changed from matching `f32` to matching `FloatOrd`'s `Ord` ordering,\nnever returning `None`.","shortMessageHtmlLink":"Fix <code>Ord</code> and <code>PartialOrd</code> differing for <code>FloatOrd</code> and optimize impl…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEO-9oWAA","startCursor":null,"endCursor":null}},"title":"Activity · pgavin/bevy"}