Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation flow hangs in navToLast() #4

Open
daneroo opened this issue Jan 1, 2020 · 1 comment
Open

Navigation flow hangs in navToLast() #4

daneroo opened this issue Jan 1, 2020 · 1 comment

Comments

@daneroo
Copy link
Contributor

daneroo commented Jan 1, 2020

In a navigation flow where navToEnd and navToLast are invoked (i.e. no --start or .lastdone present), navToLast goes into an infinite loop.

This seems to be due to a recent change in the web app's behavior.

  • navToLast starts by entering the Detail/Photo page by sending a \n
  • This assumes that an element on the Main/Album page is selected/focused.

What has changed is that the action of scrolling (navToEnd) no longer preserves a selected item, so that the \n in navToLast has no effect, and goes into an infinite loop.

Would like to know if I am the only one experiencing this.

@daneroo
Copy link
Contributor Author

daneroo commented Jan 1, 2020

I created a PR 3 which addresses the issue but also replaces the CaptureScreenshot with a DOM Query in NavToEnd.

That PR adresses this issue by explicitly setting the focus on an image element at the end of navToEnd, which restores the requirements/assumptions of navToLast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant